Add new criu kokkos test to the rocm-tests coverage - #67
Open
arunkumar-AMD wants to merge 2 commits into
Open
Conversation
mparamas-amd
requested changes
Aug 3, 2026
| @@ -0,0 +1,430 @@ | |||
| # Copyright Advanced Micro Devices, Inc. | |||
Contributor
There was a problem hiding this comment.
most comments for PR#63, PR#65-66 applies for this PR.
| return _CHECKPOINT["pid"] | ||
|
|
||
|
|
||
| @pytest.mark.runtime.medium |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CRIU (Checkpoint/Restore In Userspace) with the AMD amdgpu_plugin is what lets a running GPU workload be checkpointed to disk and later restored — the foundation for fault tolerance, preemption, and migration of long-running HPC jobs on AMD GPUs. That checkpoint/restore path over a real HIP compute workload built from a large CMake project was not covered by our end-to-end framework. This PR automates checkpoint/restore of the Kokkos performance benchmark as a marker-compliant rocm-tests e2e test, so the GPU C/R path (criu dump → criu restore with amdgpu_plugin) is validated against a live HIP process as part of our recovery coverage. This is a correctness check, not a throughput benchmark: "good" means Kokkos builds with HIP, a running Kokkos_PerformanceTest_Benchmark is checkpointed cleanly, and the restored process resumes as the same workload on the GPU.
Technical Details
readiness+auto-install fixture, and the shared _checkpoint / _restore step helpers — no CRIU logic was forked.
Test Plan
Ran checkpoint/restore of the Kokkos benchmark end-to-end through the framework on an AMD GPU node (gfx90a, ROCm 7.14.0):
Required
Optional env
Optional flags
Invocation
pytest tests/e2e/recovery/criu/test_criu_kokkos.py -v --rock-dir <therock directory>Verified the framework clones + builds Kokkos with the HIP backend, launches the benchmark on an acquired GPU, checkpoints the running process (dump → OK + PID_GONE), restores it (Restore finished successfully), and confirms the resumed PID is still the Kokkos_PerformanceTest_Benchmark workload — with the exit/marker backstops enforced.
Test Result
CRIU Kokkos checkpoint/restore: 2 passed, 0 failed, 0 skipped, 0 error (2 passed in 71.66s).
