Skip to content

feat(hip_runtime): add device-side allocation + multi-instance tests - #59

Open
y1k2chaitanya wants to merge 1 commit into
mainfrom
users/kyenumul/hip-runtime-deviceside-multiinstance
Open

feat(hip_runtime): add device-side allocation + multi-instance tests#59
y1k2chaitanya wants to merge 1 commit into
mainfrom
users/kyenumul/hip-runtime-deviceside-multiinstance

Conversation

@y1k2chaitanya

@y1k2chaitanya y1k2chaitanya commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds two functional HIP-runtime suites (shift-left from TMS):

  • test_deviceside_malloc.py (TMS 1000024 HIP_Deviceside_Malloc) — 5 parametrized in-kernel dynamic-allocation scenarios: malloc, new, per_thread, per_block, across_kernels. Each allocates inside the kernel, writes host-verified values, asserts a PASSED sentinel with no allocation fault.
  • test_multi_instance.py (TMS 1002308 / 1002309) — two concurrent instances of a self-verifying HIP vector-add via HIP_VISIBLE_DEVICES: same_gpu (both on device 0) and two_gpu (@gpu_count(2), one per GPU).

New vendored public sources under src/: device_side_alloc.cpp, hip_multi_instance_app.cpp, gated behind dedicated CMake options so existing fixtures are untouched.

Provenance / OSS-safety

Re-authored from the standard public HIP device-side-allocation feature and a trivial public vector-add — no internal/NDA payload reused.

Test plan

  • pytest --collect-only --no-gpu (marker lint) — 7 collected
  • Local GPU validation on quanta MI325 (gfx942): 7/7 passed
  • e2e CI dispatch on linux-gfx94x-MI325: passedrun 30346057930 (12 passed, 288 deselected; test_multi_instance_two_gpu is hw.multi_gpu and correctly deselected on the 1-GPU runner, covered by the quanta 2-GPU run)

@y1k2chaitanya

Copy link
Copy Markdown
Contributor Author

CI validation — e2e-tests.yml on linux-gfx94x-MI325 (gfx942)

Ran via the integration branch users/kyenumul/wave12-ci (all three Wave 1+2 areas), isolated with keyword_filter="deviceside_malloc or multi_instance or stream_priority or zero_mat":

12 passed, 288 deselected in 27.79s

Run: https://github.com/ROCm/rocm-tests/actions/runs/30346057930

(test_multi_instance_two_gpu is hw.multi_gpu and is correctly deselected on the 1-GPU runner.)

@y1k2chaitanya
y1k2chaitanya marked this pull request as ready for review July 28, 2026 10:52
@y1k2chaitanya
y1k2chaitanya requested a review from a team as a code owner July 28, 2026 10:52
- test_deviceside_malloc.py: 5 parametrized in-kernel allocation scenarios
  (malloc/new/per_thread/per_block/across_kernels) via a re-authored public
  device_side_alloc HIP workload.
- test_multi_instance.py: concurrent multi-instance execution via
  HIP_VISIBLE_DEVICES (same-gpu + two-gpu@gpu_count(2)).

New src: device_side_alloc.cpp, hip_multi_instance_app.cpp (gated CMake options).
Validated 7/7 on quanta MI325 (gfx942).
@y1k2chaitanya
y1k2chaitanya force-pushed the users/kyenumul/hip-runtime-deviceside-multiinstance branch from 5c180a0 to d477fc2 Compare July 30, 2026 20:02
@mparamas-amd mparamas-amd added the Review PR ready for review label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review PR ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants