ci: validate stack bumps nightly instead of on every PR raise - #345
Open
amd-vivekag wants to merge 1 commit into
Open
ci: validate stack bumps nightly instead of on every PR raise#345amd-vivekag wants to merge 1 commit into
amd-vivekag wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves stack-bump GPU validation from per-PR execution to nightly and on-demand evaluation, reducing contention on the shared MI350 runner.
Changes:
- Removes the per-PR bump validation workflow.
- Updates workflow comments to describe nightly/on-demand validation.
- Documents the revised bump-validation process.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/bump-validate.yml |
Removes per-PR GPU validation. |
.github/workflows/eval-reusable.yml |
Updates reusable workflow documentation. |
.github/workflows/nightly-eval.yml |
Documents nightly and dispatched validation. |
config/ci/nightly_eval_matrix.yaml |
Clarifies an excluded workload’s nightly impact. |
docs/ci-nightly-eval.md |
Documents nightly and on-demand bump validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Phase 4 of #303 wired bump-validate.yml, which ran the full GPU evaluation matrix on the single self-hosted MI350 runner for every PR touching the stack-defining files (docker/**, requirements*.txt, config/ci/ci-constraints.txt). Dependabot opens weekly pip/docker/actions bump PRs that hit exactly those paths, so every automated bump kicked off a heavy per-PR GPU run and serialized the shared runner. nightly-eval.yml already installs the wheel, builds the pinned ROCm container from the repo, and runs the identical matrix + baseline comparison against main -- so a merged stack bump is exercised by the very next nightly. Retire the per-PR trigger and rely on the nightly run (plus workflow_dispatch for on-demand confirmation of a specific bump). - Delete .github/workflows/bump-validate.yml. - Update the eval-reusable.yml / nightly-eval.yml comments to reflect that the reusable eval is nightly + on-demand, not per-PR. - Update docs/ci-nightly-eval.md and the matrix comment to document that bumps are validated nightly rather than per-PR raise. Closes #344. Refs #303. Co-authored-by: Cursor <cursoragent@cursor.com>
amd-vivekag
force-pushed
the
ci/bump-validate-nightly
branch
from
August 7, 2026 12:58
5cb3767 to
764e4a7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
docs/ci-nightly-eval.md:143
- This dispatch path is not isolated bump validation.
nightly-eval.ymlalways calls the reusable workflow withdo_alert: true, and itspublishjob runs for every non-skipped dispatch. Running a PR branch can therefore file or close the canonicalnightly-regressionissue and overwriteci-results/results/<today>.jsonwith unmerged results. Please gate alerting/publishing to canonical nightly runs (or add a non-publishing bump-validation mode) before recommending this path; the instructions should also say to select the bump branch.
matrix + baselines; use **Actions -> Nightly Evaluation -> Run workflow**
(`workflow_dispatch`) if you want to confirm a specific bump on demand.
This was referenced Aug 7, 2026
amd-vivekag
added a commit
that referenced
this pull request
Aug 10, 2026
Copilot review on PR #348: - Add a validate-requirements matrix job (py3.10-3.12) that installs requirements.txt + requirements-dev.txt and gate auto-merge on it, since no other required check exercises those files (an incompatible pin could otherwise merge green). - That check surfaced real breakage: matplotlib==3.11.1 / numpy==2.5.1 / pandas==3.0.5 require Python >=3.11, so they cannot install on 3.10 (a supported version). Re-pin to the latest 3.10-compatible releases (matplotlib==3.10.9, numpy==2.2.6, pandas==2.3.3). - Pin dependabot/fetch-metadata to a commit SHA (mutable v2 tag on a merge-capable, write-permission workflow). - Make the pip group explicit (applies-to: version-updates) and document the security-update exception to the one-PR/grouped contract. - Update docker/Dockerfile.ci-gpu comment: base image is bumped manually, not tracked by Dependabot. - docs: correct the required-check names (aggregate `CPU tests` + `pre-commit`, not per-version pytest legs) and the GPU/bump-validate relationship (this relies on #345 removing bump-validate.yml). Refs #303. Closes #346. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves Phase-4 bump validation (from #303) to the nightly run instead of running the full GPU evaluation matrix on every PR raise.
bump-validate.ymltriggeredeval-reusable.yml(timeout-minutes: 150) on the single self-hosted MI350 runner for every PR touchingdocker/**,requirements*.txt, orconfig/ci/ci-constraints.txt. Dependabot (.github/dependabot.yml) opens weekly pip / docker (ROCm digest) / github-actions bump PRs that hit exactly those paths, so every automated bump kicked off a heavy per-PR GPU run and serialized the shared runner behind bump/CI PRs.nightly-eval.ymlalready installs the wheel, builds the pinned ROCm container from the repo, and runs the identical matrix + baseline comparison againstmain— so a merged stack bump is exercised by the very next nightly. This PR retires the per-PR trigger and relies on the nightly run, keepingworkflow_dispatchfor on-demand confirmation of a specific bump.Changes
.github/workflows/bump-validate.yml(the per-PR GPU eval trigger).eval-reusable.yml/nightly-eval.ymlcomments to reflect that the reusable eval is nightly + on-demand dispatch, not per-PR.docs/ci-nightly-eval.md(and thenightly_eval_matrix.yamlcomment) that bumps are validated nightly rather than on each PR raise.Why this is safe
Test plan
docker/**/requirements*.txt/config/ci/ci-constraints.txtno longer triggers a GPU eval on raise.Nightly Evaluationstill runs the matrix + baseline comparison and files/closes thenightly-regressionissue.workflow_dispatchonNightly Evaluationstill works for on-demand bump validation.Closes #344. Refs #303.