Added incremental stamp/hash check for aiter checkout - #5
Conversation
* Initial implementation of floating commit * Updated to use only transient checkout of AITER (gitignored) * Update to patch-based build * Updated transient checkout staging area * Offset patch * Include third_party spec for AITER API * Add temporary CK patch * Added QoLA checkout CLI command * Updated patch * Added apply non-3way bypass for CK submodule patches * Rebased patches * Added gfx-1250 changes * Updated fwd path w/ stream guard * Cherry-pick from Disentangle AITER subcommit from QoLA commit (#5) * Add skip checkout option * Let override hsa_sbdirs * Added entrypoint for workspace calc * Updated guards for CK-free build * Add AITER top-left mask to bottom-right patch * Add device-side workspace prep kernel * Update zeroing policy for dq_acc * Corrected memory zeroing from AITER side * Corrected patch --------- Co-authored-by: Ilya Panfilov <ipanfilo@amd.com>
ipanfilo
left a comment
ipanfilo
left a comment
There was a problem hiding this comment.
The proposed change will skip re-sync even if aiter tree manually updated after writing stamp key. On one hand it it is flaw that does not guarantee tree state. On the other hand it gives developer flexibility to run build with local AITER changes. What is desired goal of thi change?
Main intent is to enable a more generalized caching of build for TE's cmake build system to be able to skip redundant checkouts. The ability to mutate without forcing a new checkout is something that can be mediated via |
2 participants
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist