Fix host dispatch benchmark timing window - #923
Closed
jhinpan wants to merge 1 commit into
Closed
Conversation
Move the final synchronization outside the measured window so the benchmark matches its documented host-dispatch semantics, and lock the ordering with a regression test.
Collaborator
Author
|
Superseded by #924, which carries this validated host-dispatch fix and implements the full timing-contract, event-timer cleanup, raw-us schema, verified graph benchmark, and calibrated CI gate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bench_wallclock's measured interval so it measures host dispatch as documentedWhy
The previous implementation sampled the end timestamp after
torch.cuda.synchronize(). For GPU-bound workloads that turns the metric into roughlymax(host submit, GPU throughput)rather than CPU dispatch overhead, contradicting the function's docstring and making results workload-size dependent.Test plan
python3 -m pytest tests/unit/test_launch_overhead.py -qpython3 -m ruff check tests/unit/test_launch_overhead.py