Conversation
A run that aborts before or during dispatch left the UI with no toast, only a log line. Two independent gaps: Bug 1: the socketIO log appender was unified onto a single "WHEEL_LOG" event (f24aac5, "revamp log screen"), so the per-level "logERR" event the client's onLogErr toast handlers (Home/Viewer/Workflow/remotehostManager) listen for is no longer emitted. Re-emit FATAL only on "logERR" as plain text - the log screen still receives everything via "WHEEL_LOG", and only run-aborting errors pop a toast. Bug 2: onRunProject/onContinueProject fire runDispatcher without awaiting it and projectOperator resolves the socket ack with ack(true) first, so the ack(err) in runDispatcher's preparing-phase and parsing-workflow catch blocks is a dropped second ack. Notify the client with a "showMessage" toast from those catch blocks. Server-side only; no client change. Refs #131 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C3jKNM1qubomM8UTRdkEWu
Collaborator
Author
|
他にもログ関連で修正が必要な内容が見つかったため、破棄 |
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131
プロジェクト実行/再開が dispatch 前・dispatch 中に失敗しても、クライアントにトーストが出ずログ画面に出るだけ、という 2 つの独立した不具合を修正する。サーバ側のみ（クライアント変更なし）。
Bug 1 — per-level ログイベントが emit されない
f24aac5（"revamp log screen"）でsocketIOAppenderがWHEEL_LOG一本化され、logERR等の per-level イベントが飛ばなくなった。クライアントのonLogErr-> トースト（Home/Viewer/Workflow/remotehostManager）はlogERRを購読したままで、事実上死んでいた。server/app/logSettings.js:logERRへ plain text で重複 emit。ログ画面は従来どおりWHEEL_LOGで全件受ける。ERROR まで送るとトーストが煩いので FATAL 限定。messageだけに落とす小ヘルパformatToastMessage()を追加（formatLogArg()はスタックを含むため）。Bug 2 — runProject の非同期失敗が socket ack に届かない
onRunProject/onContinueProjectはrunDispatcherを await せず、projectOperatorが先にack(true)。その後runDispatcherの catch でack(err)しても socket.io の二重 ack で無視される。server/app/handlers/projectController.js:runDispatcherの preparing phase / "parsing workflow" の 2 つの catch でemitAll(projectRootDir, "showMessage", ...)を追加（dispatcher.jsのinputFile not found通知と同じ idiom）。CANCELED（パスワード入力キャンセル）は従来どおり通知しない。動作確認
node --check両ファイル pass。failed to start project: ...トースト（Bug2 preparing catch）。project run aborted: ...トースト（Bug2 parsing catch）+ FATAL ログがあればlogERRトースト（Bug1）。WHEEL_LOG）表示は不変。🤖 Generated with Claude Code
https://claude.ai/code/session_01C3jKNM1qubomM8UTRdkEWu