fix(engine): support validated TP x PP topologies - #29
Draft
ShuhaoZhangTony wants to merge 1 commit into
Draft
Conversation
Replace the TP-equals-device-count gate with a TP-times-PP invariant and keep pipeline-parallel CLI arguments consistent with the managed environment. Generated with AI assistance; reviewed and tested by the committer.
Contributor
Author
|
CI triage: the scoped launcher checks are green ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TP == device countlauncher gate withTP x PP == device count--pipeline-parallel-sizeconsistently and record the managed topologyThe previous gate made a valid four-card PP2 x TP2 Pipeline Microbatch qualification impossible. This change does not introduce TP1/eager/legacy fallback.
Tests
bash -n tools/run_vllm_engine.sh: passedpython -m pytest -q tests/test_systemd_service_scripts.py: 16 passedgit diff --check: passedQualification boundary
The Mod was runtime-effective and functionally correct, but matched performance regressed; the tested configuration remains unsupported pending fresh calibration.
Contribution disclosure
AI assistance was used to diagnose the topology gate, edit the launcher, and run tests. Human line-by-line review is required before merge.