Develop v2.1.0

[ivis-miyachi]

Summary by Sourcery

Chores:

• Correct the migration dependency for adding file read-only keys.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Alembic migration dependency so the file read-only keys migration follows revision 8ae99b034410 instead of 8644b32a3eec, keeping the migration graph aligned for v2.1.0.

Flow diagram for the v2.1.0 migration dependency

flowchart LR
    R[8ae99b034410] --> F[faf4faa08601<br/>Add file read-only keys]

Loading

File-Level Changes

Change	Details	Files
Rebases the read-only file keys migration onto the updated Alembic migration chain.	Changes the migration's immediate predecessor revision identifier.	modules/invenio-files-rest/invenio_files_rest/alembic/faf4faa08601_add_column_file_readonly_keys.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: ca573437-e48e-4c36-ac84-22613eaa29dc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🔍 Claude レビュー統合

指摘はありません。

---

次にすること: 差分は変更なしで問題ありません。faf4faa08601 の down_revision を、存在しない 8644b32a3eec から実在する 8ae99b034410 に直しただけです。files-rest の alembic は 52ce868f33c3 → 2e97565eba72 → f741aa746a7d → 8ae99b034410 → faf4faa08601 の一本道になり、head が一つに収まります。レビュー指摘は Sourcery の要約と CodeRabbit のスキップ通知だけで、裁定すべきスレッドはありません。

---

_{モデル sonnet ／ 2 回実行して和集合 ／ コスト $0.1551。同じ入力でも結果が揺れるため複数回まわし、一部のパスでしか挙がらなかったものには回数を添えています}

_{他レビューを踏まえた自動レビューです。誤りが含まれることがあります。}

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="modules/invenio-files-rest/invenio_files_rest/alembic/faf4faa08601_add_column_file_readonly_keys.py" line_range="16" />
<code_context>
 # revision identifiers, used by Alembic.
 revision = 'faf4faa08601'
-down_revision = '8644b32a3eec'
+down_revision = '8ae99b034410'
 branch_labels = ()
 depends_on = None
</code_context>
<issue_to_address>
**Location upgrades and queries fail**

When a fresh database is upgraded, or an existing database is at `8644b32a3eec`, `faf4faa08601` skips `8644b32a3eec`, so Alembic cannot plan upgrades from that revision, and fresh schemas miss the S3 columns. Existing rows also miss the read-only-key columns; location access then fails with a database error.

Restore `8644b32a3eec` as `down_revision` so Alembic follows the migration chain and applies the required column migrations.
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and this changes the Alembic migration graph, so an incorrect dependency could make upgrades run in the wrong order or fail, potentially leaving a partially applied schema change. Reverting fixes future migration runs, while any already-applied schema state would need a migration rerun or repair.

Blocking findings: modules/invenio-files-rest/invenio_files_rest/alembic/faf4faa08601_add_column_file_readonly_keys.py:16

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[sourcery-ai]

🟠 High · Location upgrades and queries fail

When a fresh database is upgraded, or an existing database is at 8644b32a3eec, faf4faa08601 skips 8644b32a3eec, so Alembic cannot plan upgrades from that revision, and fresh schemas miss the S3 columns. Existing rows also miss the read-only-key columns; location access then fails with a database error.

Restore 8644b32a3eec as down_revision so Alembic follows the migration chain and applies the required column migrations.

Prompt for AI agents

In `modules/invenio-files-rest/invenio_files_rest/alembic/faf4faa08601_add_column_file_readonly_keys.py` at line 16:

**Location upgrades and queries fail**

When a fresh database is upgraded, or an existing database is at `8644b32a3eec`, `faf4faa08601` skips `8644b32a3eec`, so Alembic cannot plan upgrades from that revision, and fresh schemas miss the S3 columns. Existing rows also miss the read-only-key columns; location access then fails with a database error.

Restore `8644b32a3eec` as `down_revision` so Alembic follows the migration chain and applies the required column migrations.

[github-actions]

API インベントリ差分（件数のみ）

台帳ブランチ: develop_v2.1.0

明細は公開できないため件数のみ表示しています。該当箇所はプライベートリポジトリ側の台帳・レポートで確認してください。

ベースラインとの差分

API インベントリ差分レポート

• 旧: b572c442d v2.0.4-577-gb572c442d (profile=default) endpoints=933 (外部ライブラリ由来 359)
• 新: 4b5c8f335 v2.0.4-676-g4b5c8f335 (profile=default) endpoints=933 (外部ライブラリ由来 359)

判定: ❌ FAIL (FAIL 1 / WARN 3)

サマリ

分類	件数
ADDED	0
REMOVED	0
RULE_CHANGED	0
METHODS_CHANGED	0
AUTH_CHANGED	35
IMPL_CHANGED	9
ATTRS_UNKNOWN_NEW	0
ModelView 追加	0
ModelView 削除	0
ModelView フラグ変化	0
config 変化	2
コメントアウト認証の増加	0
依存パッケージの版変化	1

[FAIL] G2 認証系デコレータが削除された — 3件

件数のみ。該当の経路名はプライベートリポジトリ側の完全版レポートを参照。

[WARN] W2 実装本体が変化(data_op / 情報露出を再確認) — 9件

件数のみ。該当の経路名はプライベートリポジトリ側の完全版レポートを参照。

[WARN] W6 依存パッケージの版が変化した — 1件

• pbr — 7.0.3 -> 7.1.3

[WARN] W5 監視対象 config が変化した — 2件

件数のみ。該当の経路名はプライベートリポジトリ側の完全版レポートを参照。

---

台帳との突き合わせ

(生成されませんでした)

ソース由来の経路検知

(生成されませんでした)