feat(release): add chart_repos, release_notes_extra and notify inputs - #2
Merged
Merged
Conversation
rebel-mskim
force-pushed
the
feat/chart-repos-notes-extra-notify
branch
from
September 14, 2026 07:00
fa88d1d to
268294d
Compare
rebel-mskim
force-pushed
the
feat/chart-repos-notes-extra-notify
branch
from
September 14, 2026 07:10
268294d to
0da887b
Compare
rebel-mskim
changed the title
…update release-notes.sh chose by the executable bit: a bare filename was looked up on PATH (command not found), a markdown file that happened to be +x was executed, and a script committed without +x was pasted into the notes as text. A file is now a script iff its first line is "#!": a script without the executable bit fails with a chmod hint, a bare name runs from the checkout, anything else is appended as-is. helm repo add gets --force-update so a repository name already registered on the runner with another URL is replaced instead of failing the job. Template: "remove both chart lines" -> the chart_* lines (chart_repos is a third one now). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… ruleset line The release_notes_extra script saw VERSION on every rc pre-release but not on the GA draft, so a script that used it would fail only after ga-promote had already pushed to docker.io. Both steps now export it, and the input description says which variables the script may rely on. require_extra_approval_for_unattributed_changes is GitHub's server-side default and has no effect on a ruleset that requires zero approvals, so protect-main.json goes back to what main has. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rbln-npu-operator is adopting the kit and needs three things the reusable
releaseworkflow could not do: register a chart dependency repository, append a generated table to the release notes, and post its own Slack summary because it adds jobs afterrelease.Summary of Changes
chart_repos:name=urllist registered withhelm repo add --force-updatebeforehelm dependency buildin the rc and GA chart jobs. Without it a fresh runner fails withno repository definition for <url>.release_notes_extra: file in the caller checkout appended after Known Issues. A script (first line#!, executable) runs withVERSION,HARBOR_REGISTRY,DOCKERHUB_REGISTRY,IMAGESandCHART_DIRset and its stdout is appended; a markdown file is appended as-is. A script without the executable bit, or a path that is not a file, fails; a bare filename runs from the checkout, not from PATH.notify(defaulttrue):falseskips the kit's rc/GA Slack summaries; label deletion and everything else stay.Technical Details
v1.1.0and movev1; ci(release): adopt cloud-component-release-kit rbln-npu-operator#128 depends on it.+xmarkdown file was executed, a bare filename was looked up on PATH, a non-executable script was pasted as text); the GA release-notes step exportsVERSIONlike the rc step;helm repo add --force-update. Therequire_extra_approval_for_unattributed_changesline was dropped again: it is GitHub's server default and has no effect on a ruleset that requires zero approvals.bats tests56/56, shellcheck, actionlint; CI green on 3e54de0.🤖 Generated with Claude Code