Skip to content

[appserver-jersey] Added Docker setup, updated tests & CI, liquibase - #552

Merged
this-Aditya merged 64 commits into
restructure-projectfrom
docker-setup-jersey
Jul 27, 2026
Merged

this-Aditya merged 64 commits into
restructure-projectfrom
docker-setup-jersey

Conversation

@mpgxvii

@mpgxvii mpgxvii commented Jul 23, 2026

Copy link
Copy Markdown
Member

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. java Pull requests that update Java code labels Jul 23, 2026
@this-Aditya

this-Aditya commented Jul 27, 2026

Copy link
Copy Markdown
Member

Hi @mpgxvii, thanks for the PR -- I diffed appserver-jersey/ between this branch and 36c77ff, the last commit in the #542#551 chain that still has the jersey module, and there is newer work here that isn't in the chain at all, but some files differ and a few fixes from #550 and #551 is not synced.

Changes from 75cfe4d from #551, "Make Quartz DB-backed and compatible with legacy-scheduled jobs", is missing. QuartzSchedulerFactory is back to a StdSchedulerFactory(), which is an in-memory RAMJobStore, so scheduled notifications don't survive a restart. SchedulerConfig doesn't have JDBC settings and the quartz: block in appserver.yml. MessageJob also moved back under ...jersey.service.quartz. It was kept in the legacy package because Quartz stores the class name in QRTZ_JOB_DETAILS.JOB_CLASS_NAME, so jobs written by the Spring app server won't resolve anymore.

Rest of what I found:

What Where From
checkPresence(doesntExists, ...) never fires, checkPresence only throws on null and this is a non-null Boolean TaskService.kt 0f4872d from #550
Missing return after the "no email address" warning, so it tries to send anyway EmailTransmitter.kt 804d699 from #550
Permission checked against token.subject instead of fcmUserDto.subjectId UserResource.kt 804d699 from #550
Two leftover debug println calls in updateProject ProjectService.kt 804d699 from #550
Path is /filter, legacy uses /filtered FcmNotificationResource.kt 79af7dc from #550
SUBJECT_READ on the GETs, legacy uses UPDATE TaskStateEventResource.kt 79af7dc from #550
schedule param defaults to false, chain has true FcmNotificationResource.kt 79af7dc from #550
Lost @CollectionTable(name = "notification_additional_data") Notification.kt 89d26ff from #551
Lost joinColumns = [JoinColumn(name = "data_message_id")] DataMessage.kt 4549aca from #551
Still on the rigid HH:mm:ss.SSSXXX pattern instead of HH:mm:ss[.SSS]XXX, this is what broke the integration tests last time ProjectDto.kt, FcmDataMessageDto.kt, FcmUserDto.kt f875477 from #551
Swagger UI dropped, Enhancers.swagger(...) plus @Tag on all 8 resources AppserverResourceEnhancerFactory.kt abe7bcf from #550
Dropped Task.equals/hashCode and the LinkedHashSet in the two repeat handlers. The PersistenceException catch here only dedups notifications, not tasks Task.kt ac85c63 from #550
radarJerseyVersion down from 0.12.7 to 0.12.2 Versions.kt 0a91a03 from #551

I noticed but wasn't sure about, they may be deliberate. Task.kt uses GenerationType.AUTO where the chain and legacy both use SEQUENCE.

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 27, 2026
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jul 27, 2026
@mpgxvii

mpgxvii commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

@this-Aditya Thanks for double checking. It seems that the newest changes (db-quartz) did not get pulled so the changes were not added here. I've added the latest commits now.

@this-Aditya this-Aditya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @mpgxvii

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 27, 2026
@this-Aditya
this-Aditya merged commit 7fc116d into restructure-project Jul 27, 2026
0 of 2 checks passed
@this-Aditya
this-Aditya deleted the docker-setup-jersey branch July 27, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants