You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @mpgxvii, thanks for the PR -- I diffed appserver-jersey/ between this branch and 36c77ff, the last commit in the #542 → #551 chain that still has the jersey module, and there is newer work here that isn't in the chain at all, but some files differ and a few fixes from #550 and #551 is not synced.
Changes from 75cfe4d from #551, "Make Quartz DB-backed and compatible with legacy-scheduled jobs", is missing. QuartzSchedulerFactory is back to a StdSchedulerFactory(), which is an in-memory RAMJobStore, so scheduled notifications don't survive a restart. SchedulerConfig doesn't have JDBC settings and the quartz: block in appserver.yml. MessageJob also moved back under ...jersey.service.quartz. It was kept in the legacy package because Quartz stores the class name in QRTZ_JOB_DETAILS.JOB_CLASS_NAME, so jobs written by the Spring app server won't resolve anymore.
Rest of what I found:
What
Where
From
checkPresence(doesntExists, ...) never fires, checkPresence only throws on null and this is a non-null Boolean
Dropped Task.equals/hashCode and the LinkedHashSet in the two repeat handlers. The PersistenceException catch here only dedups notifications, not tasks
@this-Aditya Thanks for double checking. It seems that the newest changes (db-quartz) did not get pulled so the changes were not added here. I've added the latest commits now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javaPull requests that update Java codelgtmThis PR has been approved by a maintainersize:XXLThis PR changes 1000+ lines, ignoring generated files.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.