Enhanced Home page Weather card#113
Open
ak8057 wants to merge 1 commit into
Open
Conversation
|
@ak8057 I am not maintainer of this project. But, it would be great if you can add screenshot of what changes you have made in UI. It will be easy for reviewer. Also as a next step you can deploy your fork (and branch dedicated for this issue) on Netlify, mentioning that it is temporary deployment. This will save reviewer's time. Just suggestions. Thanks |
R0Y15
requested changes
Oct 19, 2024
R0Y15
left a comment
R0Y15
left a comment
Owner
There was a problem hiding this comment.
@ak8057 The changes are mind-blowing; I really appreciate your work. However, I'd request you a few changes in the new update:
- Please darken the background of the weather card so that the buttons are more clearly visible.
- keep the "use current location" and "chart type" buttons in the same horizontal level and not vertically.
- rather than keeping the weather card and chart vertically, if we can keep it horizontally aligned for the desktop and vertically aligned for mobile, the UI would be very fresh and would fix the issue of increasing height in desktop mode.
Author
|
Thanku for your feedbacks, I will make sure to add all the updates needed |
Owner
|
hi @ak8057, any updates on this issue? |
Author
|
yeah I will start working on this soon ,but i am currently busy with some important work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kindly merge the PR under Hacktoberfest2024.
I am open if you need any changes