Skip to content

fix: support namespaced document and window event names - #8920

Merged
wmertens merged 1 commit into
mainfrom
fix-events-escape
Aug 9, 2026
Merged

fix: support namespaced document and window event names#8920
wmertens merged 1 commit into
mainfrom
fix-events-escape

Conversation

@Varixo

@Varixo Varixo commented Aug 9, 2026

Copy link
Copy Markdown
Member

Fix namespaced document and window events by escaping qwikloader’s dynamic attribute selectors with CSS.escape(). Add regression coverage for qwik:foo dispatch and update the qwikloader snapshot.

@Varixo Varixo self-assigned this Aug 9, 2026
@Varixo
Varixo requested a review from a team as a code owner August 9, 2026 11:29
@changeset-bot

changeset-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dfe3f66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this to Waiting For Review in Qwik Development Aug 9, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8920

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8920

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8920

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8920

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8920

@qwik.dev/devtools

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/devtools@8920

commit: dfe3f66

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview dfe3f66

@wmertens wmertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎢

@wmertens
wmertens merged commit d2618bd into main Aug 9, 2026
49 checks passed
@wmertens
wmertens deleted the fix-events-escape branch August 9, 2026 21:25
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[🐞] Colon in a custom event name makes qwikloader throw SyntaxError on every dispatch

3 participants