Skip to content

fix MC-122110: BufferBuilder not expanding under specific conditions #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MicrocontrollersDev wants to merge 1 commit into from
Closed

fix MC-122110: BufferBuilder not expanding under specific conditions #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/dev/rdh/sarcio/mixin/bugfix/render/BufferBuilderMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@

import java.nio.IntBuffer;
import net.minecraft.client.render.vertex.BufferBuilder;
import net.minecraft.client.render.vertex.VertexFormat;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.ModifyArg;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;

@Mixin(BufferBuilder.class)
Expand All @@ -16,8 +18,16 @@ public abstract class BufferBuilderMixin {
@Shadow
protected abstract int getBufferIndex();

@Shadow
private VertexFormat format;

@Inject(method = {"nextVertex", "vertices"}, at = @At(value = "INVOKE", target = "Lnet/minecraft/client/render/vertex/BufferBuilder;grow(I)V"))
private void sarcio$syncBufferPosition(CallbackInfo ci) {
this.intBuffer.clear().position(this.getBufferIndex());
}

@ModifyArg(method = "vertices", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/render/vertex/BufferBuilder;grow(I)V"))
private int sarcio$buildBuffer(int amount) {
return amount + this.format.getVertexSize();
}
}
Loading