Skip to content

fix MC-117075: Performance issue with unloading large number of block entities #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MicrocontrollersDev wants to merge 3 commits into from
Closed

fix MC-117075: Performance issue with unloading large number of block entities #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b0c1d0
fix MC-117075
MicrocontrollersDev Sep 29, 2026
b029a2e
greatly simplify
MicrocontrollersDev Sep 29, 2026
b0cd37b
cleanup diff
MicrocontrollersDev Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/main/java/dev/rdh/sarcio/mixin/bugfix/world/WorldMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
package dev.rdh.sarcio.mixin.bugfix.world;

import com.llamalad7.mixinextras.injector.ModifyExpressionValue;
import it.unimi.dsi.fastutil.objects.ObjectOpenHashSet;
import net.minecraft.block.entity.BlockEntity;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.LightType;
import net.minecraft.world.World;
import org.jetbrains.annotations.NotNull;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.Unique;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.ModifyArg;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

import java.util.Collection;

@Mixin(World.class)
public abstract class WorldMixin {
@Shadow public abstract boolean isAreaLoaded(BlockPos center, int radius, boolean allowEmpty);
Expand All @@ -30,4 +36,9 @@ public abstract class WorldMixin {
private int setVariableRange(int original) {
return this.sarcio$range;
}

@ModifyArg(method = "tickEntities", at = @At(value = "INVOKE", target = "Ljava/util/List;removeAll(Ljava/util/Collection;)Z"))
private Collection<BlockEntity> sarcio$hashRemovedBlockEntities(@NotNull Collection<BlockEntity> removed) {
return new ObjectOpenHashSet<>(removed);
}
}
Loading