Skip to content

Fix addQxChangeRow crashing on the QE instance when the service is not running #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fvacek merged 2 commits into from
Oct 7, 2026
Merged

Fix addQxChangeRow crashing on the QE instance when the service is not running #1239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cb07a7
fix: crash for QE instance without service running
lukaskett Oct 5, 2026
a76cc35
feat: show late registrations table even for qe instance without serv…
lukaskett Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions quickevent/app/quickevent/plugins/Event/src/services/qx/qxlateregistrationswidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ QxLateRegistrationsWidget::QxLateRegistrationsWidget(QWidget *parent) :
ui->tableView->setTableModel(m_model);

showMessage({});
setEnabled(false);

connect(service(), &Service::statusChanged, this, &QxLateRegistrationsWidget::updateEnabled);
if (auto *svc = Service::serviceByName(OFeedClient::serviceName())) {
Expand Down Expand Up @@ -130,7 +129,7 @@ void QxLateRegistrationsWidget::onDbEventNotify(const QString &domain, int conne

void QxLateRegistrationsWidget::onVisibleChanged(bool is_visible)
{
if (is_visible && isEnabled()) {
if (is_visible) {
reload();
}
}
Expand All @@ -146,12 +145,7 @@ void QxLateRegistrationsWidget::updateEnabled()
{
auto *ofeed = qobject_cast<OFeedClient*>(Service::serviceByName(OFeedClient::serviceName()));
bool is_ofeed_running = ofeed && ofeed->isRunning();
bool is_qx_running = service()->isRunning() ;
bool is_enabled = is_qx_running || is_ofeed_running;
setEnabled(is_enabled);
if (is_enabled) {
reload();
}
reload();
// the changes are stored into this table only when the processing is switched on,
// the dock is revealed then, so that the records are not hidden from the user
if (is_ofeed_running && (ofeed->runStartChangesProcessing() || ofeed->runOfficeChangesProcessing())) {
Expand Down Expand Up @@ -204,9 +198,6 @@ void QxLateRegistrationsWidget::showMessage(const QString &msg, bool is_error)

void QxLateRegistrationsWidget::reload()
{
if(!isEnabled()) {
return;
}
auto event_plugin = getPlugin<EventPlugin>();
if(!getPlugin<EventPlugin>()->isEventOpen()) {
return;
Expand Down Expand Up @@ -257,6 +248,9 @@ void QxLateRegistrationsWidget::addQxChangeRow(int sql_id)
loadTypes(getPlugin<EventPlugin>()->currentStageId());

auto qb = m_model->queryBuilder();
if (qb.isEmpty()) {
return;
}
qb.where(QStringLiteral("id=%1").arg(sql_id));
qfs::Query q;
q.execThrow(qb.toString());
Expand Down
Loading