Repository navigation
fix(ext-tester): the standalone tester builds again (beta.2 release stopped on it) - #1841
Merged
Merged
Conversation
…ndalone tester builds again; a test keeps its imports pure Dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release run of 0.5.0-beta.2 built the app on all three platforms and passed E2E, then every
Build querya-ext-testerjob failed and the release was not published:#1717 (swallowed errors leave a line in the log) put
logIgnoredinto the harness. The tester is compiled byscripts/ci/build_ext_tester.shfromlib/core/extensionsandpackage:pathonly, andlogIgnoredpulls in Flutter and the app's log. Only the Release workflow builds the tester, so CI on the PR was green._ignoredthat writes to stderr.test/core/extensions/harness/ext_tester_pure_dart_test.dartwalks the imports reachable frombin/querya_ext_tester.dartand fails on anything that is notdart:,package:pathorcore/extensions.Checked:
scripts/ci/build_ext_tester.shrun locally now ends in a workingquerya-ext-tester(--helpprints). The new test was not run locally.