Repository navigation
fix(ui): extension tree is indented like the built-in drivers' trees - #1839
Merged
Merged
Conversation
… connection's indent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under a connection the extension tree (ClickHouse and other driver extensions) started 8 px further right than a Postgres or MySQL database list: the connection row already insets it by
underConnection(20) andSduiTreeBuilderadded another 8 for expandable roots. The extra 8 is gone; leaves keep their 4 and nested levels their 16 per level.Test: the chevron of a root row sits less than 8 px from the tree's left edge. Not run locally; CI decides. I guessed that this empty space is what the screenshot pointed at; if it is something else (the right side, the row height) say so.