Repository navigation
fix(docker): MySQL seeds are read as utf8mb4 (#1823) - #1835
Merged
Merged
Conversation
…ext is stored as written (#1823)
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image entrypoint pipes the init files through the
mysqlclient, which reads them as latin1 unless told otherwise, socol_textheld the double-encoded form of the emoji sample. Both init files now start withSET NAMES utf8mb4;. The files themselves are correct UTF-8.The MongoDB, ClickHouse and PostgreSQL seeds were checked by reading: their emoji text is plain UTF-8 and those loaders take it as is.
Not verified: it needs
docker compose down -vand a fresh start of the MySQL container, which I did not run. Existing volumes keep the old text until re-seeded.Refs #1823