Repository navigation
feat(sqlite): Overview table chips open the table (#1816) - #1833
Merged
Merged
Conversation
…h hover, tooltip and a semantics action (#1816)
github-actions
Bot
added
enhancement
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table chips on the SQLite Overview page looked like buttons and did nothing. A chip now opens the table in the table browser, the same path as choosing it in the sidebar tree (
" tooltip and a button node with a tap action.onSqliteObjectSelected, so the unsaved-changes and SQL-transaction guards apply). It has the kit's hover state, an "OpenNot done: the Open in SQL / Copy name context menu from the issue; the PostgreSQL / MySQL overviews were not checked for the same pattern.
Test: a chip tap reports the table name. Not run locally; CI decides.
Refs #1816