Repository navigation
fix(tree): rows keep their expanded branches when a connection is added (#1821) - #1830
Merged
Merged
Conversation
…ands its neighbours' expanded branches to the wrong row (#1821)
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection rows had no keys. Each row keeps its expanded databases and tables in widget state, so a connection inserted above another (the list is sorted by name) moved that state onto the wrong row: branches collapsed or opened on the neighbour and the highlight jumped.
Rows and folders are keyed by connection id / folder name, and the list gets a
findChildIndexCallbackso the state follows the key when the index shifts.Test: add "Alpha" above "Zeta"; the Zeta row's State object is the same one as before.
Refs #1821