Repository navigation
test(pool): tests for PoolEntryLock (#1683, item 1) - #1805
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1683 (item 1, the tests;
_lockitself is left as it is until we decide whether to drop it).PoolEntryLockis used by the PostgreSQL, MySQL and SQLite pools and had no tests. They pin: two callers for one key share onecreate(); different keys are created in parallel; a finished creation is forgotten; a failingcreate()fails every waiter and clears the entry; acreate()that throws synchronously does not wedge the lock. Test-only. CI will run them.