Repository navigation
fix(mcp): hardening gaps of the review (#1776) - #1802
Merged
Merged
Conversation
…activity persist errors are logged, concurrent access toggles do not lose one, a huge list is refused (#1776)
github-actions
Bot
added
bug
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1776. Done:
McpSocketHost: an authenticated line longer thanmaxLineBytes(4 MiB) closes the connection instead of buffering without bound; at mostmaxSessions(16) authenticated connections, more get 'Too many Querya MCP sessions.'.McpServerController._start: ifhost.start()throws after binding the socket, the host is stopped instead of listening with a token nobody has.McpServerController._persist: the activity write is no longer a bareunawaited; its error is logged.McpAccessStore.setReadable: calls run one after another, so two quick toggles do not lose one.McpMongoGuard: list items count towardmaxKeys, so a huge$inis refused.Not done here, still open in #1776: Mongo
maxTimeMSand a total response size cap (the session interface has no way to pass the option yet), and masking the connection's own secrets for non-tool exceptions in_guarded. The access-store serialization has no test: it needs the local database. Not run locally, CI will.