Repository navigation
deps: refresh_rate 2.0.1 from pub.dev, drop the vendored fork (#1584) - #1725
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1584
third_party/refresh_rate(1.0.2 plus a Linux-Werrorfix and a macOS Swift package path fix) is gone;pubspec.yamltakesrefresh_rate: ^2.0.1and thedependency_overridesentry is removed.Checked before switching (the issue's first task):
afewgoodcoders.com; the repository moved fromqoder-official/refresh_rate(up to 1.0.2) toafewgoodcoders/refresh_rateat 2.0.0, and the Android package is stillin.qoder.refresh_rate. That fits a hand-over or rename of the maintainers; I cannot prove it from here, so the decision is yours.refresh_rate_plugin.cc, 130 lines:g_getenvofWAYLAND_DISPLAY/DISPLAY, GDK monitor query), Windows (refresh_rate_plugin_c_api.cpp, 197 lines), macOS (RefreshRatePlugin.swift, 89 lines: display link and power / thermal notifications). No network, no process execution, no file writes, no library loading; the Dart side has nodart:ioor HTTP. The rest is Pigeon-generated.App changes:
DisplayRefreshServicewrapsRefreshRate.enable()inunawaited(it returns a result now) and notes the two behaviour changes: an unknown rate reads 0 Hz instead of 60, andinfofills in asynchronously, so the first debug log can show 0 Hz. Docs that named the vendored plugin are updated.Verified here (Linux):
flutter build linux --debugbuilds; the profile bench starts the app with the plugin (displayHz=120); motion and app tests pass. Not verified: Windows and macOS builds (CI builds them on this PR); the macOS minimum stays 10.14 for the plugin.Not changed:
flutter.config.enable-swift-package-manager: falsestays. It turns Swift Package Manager off for every plugin, and its reason (the vendored plugin's brokenPackage.swift) no longer applies, but turning it on is a macOS build change I cannot try on Linux; the comment says so. That is the issue's separate follow-up.Fallback if the Windows or macOS build breaks on 2.0.1: put the fork back and re-vendor 2.0.1 with only the needed patch.