Repository navigation
refactor(shell): split MainScreen into a layout, a navigator, dialogs and a pure shortcut table (#1503) - #1718
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1503
main_screen.dartwent from 1773 to 390 lines. No behaviour change; each step was checked with the main_screen, e2e, guards and app tests locally.main_content_split.dartmain_screen_shortcuts.dartMainScreenShortcuts.resolve(event, cmdOrCtrl, shift, alt)returns aMainShortcut(pure, Russian layout included); the screen only maps it to an actionmain_screen_navigator.dartmain_screen_dialogs.dartmain_screen_chrome.dartShellTitleBarandShellStatusBaras widgetsMainContentSplitStatelost its underscore with the move; the perf bench looks it up by name and is updated.Tests added: the shortcut table per key, modifier and layout; the navigator (repeat pick is a no-op, the pending Mongo collection and its notification, Redis, close vs home). The existing safe-mode, sidebar, file-launch and e2e shell tests are unchanged and pass.
One thing I left alone: the build still has a
CallbackShortcutsmap that repeats most of what the global handler does; removing it is a behaviour question, not part of this split.