You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(sql-workspace): cancelling the destructive-query dialog still throws away the staged table edits #1771
In `generic_sql_workspace.dart` (run path), `confirmDiscardTableEditsIfDirty` is asked first, and when the user agrees the staging buffer is disposed immediately. The destructive-query confirmation comes after that. If the user then cancels it, the query does not run, but the staged edits are already gone.
Fix
Dispose the buffer only after every confirmation has passed (just before the query starts), or ask the destructive question first. Add a widget test: dirty buffer, destructive SQL, answer "discard" and then "cancel" keeps the buffer.
Activity
test(sql-workspace): wait for the real settings read after Discard (#…
test(sql-workspace): do not wait for a spinner to settle, run the poo…
test(sql-workspace): let the closing dialog finish its transition bef…
Merge pull request #1785 from QueryaHub/fix/destructive-cancel-keeps-…
ZhuchkaTriplesix commentedon Oct 25, 2026
Fixed on dev in #1785 (merged). Closing by hand: the PRs target dev, so GitHub would only close this when dev is merged into main.