Repository navigation
Static size for unbounded dimensions in the Manhattan indexing - #117
Merged
Merged
Conversation
The values of an infinite sector type now have size `Unbounded()` instead of `typemax(Int)`, so that the inclusion-exclusion over the bounds leaves out the unbounded dimensions at compile time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
…sizes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lkdvos
approved these changes
Oct 21, 2026
Merged
leburgel
added a commit
to QuantumKitHub/SUNRepresentations.jl
that referenced
this pull request
Oct 22, 2026
Uses `TensorKitSectors.Unbounded` (QuantumKitHub/TensorKitSectors.jl#117), which also speeds up `getindex`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this suggestion: infinite sector types now have the size
Unbounded()instead oftypemax(Int)in the Manhattan indexing, so that the inclusion-exclusion of #115 leaves out their bounds at compile time. Finite products get faster too; that comes from building the tuple of bounded sizes, but I haven't tracked down why.findindexbeforegetindexbeforeU1Irrep ⊠ SU2IrrepFermionParity ⊠ U1Irrep ⊠ SU2Irrep ⊠ U1IrrepZ4Irrep ⊠ Z4Irrep ⊠ Z4IrrepZ3Irrep ⊠ IsingAnyon ⊠ FibonacciAnyonWith SUNRepresentations passing
Unbounded()as well (which would replace QuantumKitHub/SUNRepresentations.jl#60),findindexfor SU(4) / SU(5) goes from 26 / 65 to 7 / 11 ns, andgetindexfrom 310 / 420 to 175 ns.Reproducer
🤖 Generated with Claude Code