Repository navigation
Fix promote_storagetype in planar preprocessor - #577
Merged
Merged
Conversation
lkdvos
reviewed
Oct 12, 2026
lkdvos
approved these changes
Oct 12, 2026
kshyatt
force-pushed
the
ksh/planar_storagetype
branch
from
October 12, 2026 21:00
1bf40af to
ff079a9
Compare
kshyatt
enabled auto-merge (squash)
October 12, 2026 21:01
Jutho
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was definitely introduced by me, sorry 😞 . The calling convention here for
promote_storagetypewas wrong. I added the single tensor version toabstracttensor.jlto avoid having to do a length check.