Skip to content

Drop some unneeded Enzyme rules #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kshyatt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop some unneeded Enzyme rules #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da13f57
Remove unneeded fwd tr rule
kshyatt Oct 8, 2026
0546832
Drop twist rules
kshyatt Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions ext/TensorKitEnzymeExt/indexmanipulations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,57 +183,6 @@ function EnzymeRules.forward(
end
end

# Differentiating through the fusion tree loop corrupts the
# heap on Julia 1.10 and causes segfaults in the GC. Remove this
# custom rule when we drop support for 1.10
function EnzymeRules.augmented_primal(
config::EnzymeRules.RevConfigWidth{1},
func::Const{typeof(twist!)},
::Type{RT},
t::Annotation{<:AbstractTensorMap},
inds::Const;
inv::Bool = false
) where {RT}
twist!(t.val, inds.val; inv)
primal = EnzymeRules.needs_primal(config) ? t.val : nothing
shadow = EnzymeRules.needs_shadow(config) ? t.dval : nothing
return EnzymeRules.AugmentedReturn(primal, shadow, nothing)
end

function EnzymeRules.reverse(
config::EnzymeRules.RevConfigWidth{1},
func::Const{typeof(twist!)},
::Type{RT},
cache,
t::Annotation{<:AbstractTensorMap},
inds::Const;
inv::Bool = false
) where {RT}
!isa(t, Const) && twist!(t.dval, inds.val; inv = !inv)
return (nothing, nothing)
end

function EnzymeRules.forward(
config::EnzymeRules.FwdConfigWidth{1},
func::Const{typeof(twist!)},
::Type{RT},
t::Annotation{<:AbstractTensorMap},
inds::Annotation;
inv::Bool = false
) where {RT}
twist!(t.val, inds.val; inv)
!isa(t, Const) && twist!(t.dval, inds.val; inv)
if EnzymeRules.needs_primal(config) && EnzymeRules.needs_shadow(config)
return Duplicated(t.val, t.dval)
elseif EnzymeRules.needs_primal(config)
return t.val
elseif EnzymeRules.needs_shadow(config)
return t.dval
else
return nothing
end
end

function EnzymeRules.augmented_primal(
config::EnzymeRules.RevConfigWidth{1},
func::Const{typeof(flip)},
Expand Down
24 changes: 0 additions & 24 deletions ext/TensorKitEnzymeExt/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,30 +125,6 @@ function EnzymeRules.reverse(
)
return (nothing,)
end
function EnzymeRules.forward(
config::EnzymeRules.FwdConfigWidth{1},
::Type{RT},
func::Const{typeof(tr)},
A::Annotation{<:AbstractTensorMap},
) where {RT}
y = EnzymeRules.needs_primal(config) ? tr(A.val) : nothing
Δy = if EnzymeRules.needs_shadow(config) && !isa(A, Const)
tr(A.dval)
elseif EnzymeRules.needs_shadow(config)
zero(eltype(A.dval))
else
nothing
end
if EnzymeRules.needs_primal(config) && EnzymeRules.needs_shadow(config)
return Duplicated(y, Δy)
elseif EnzymeRules.needs_primal(config)
return y
elseif EnzymeRules.needs_shadow(config)
return Δy
else
return nothing
end
end
function EnzymeRules.augmented_primal(
config::EnzymeRules.RevConfigWidth{1},
func::Const{typeof(norm)},
Expand Down
Loading