Skip to content

Unify CPU and GPU tree transformer code paths #578

Open

Description

@lkdvos

Follow-up to #556 (see #556 (comment)).

The GPU path already passes the flat data vectors to add_transform_kernel! and keeps all the subblock structure (strides/offsets) inside the device transformer. The CPU path instead builds StridedSubblocks for both tensors and passes those in alongside the transformer. Doing the same on the CPU, i.e. passing the flat data vector and keeping the subblock information in the transformer, would make the two code paths more uniform and easier to follow.

This changes the CPU kernel signatures, so it should be benchmarked against the current implementation.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions