Skip to content

pinv(::DiagonalTensorMap) atol/rtol defaulting is inverted #545

Closed

Description

@lkdvos

Defaulting logic is backwards vs. LinearAlgebra.pinv and this repo's own convention (linalg.jl:288): atol==0 disables rtol entirely (no truncation at all — reproduced: near-zero singular value inverts to ~1e14 instead of being zeroed), while passing atol>0 force-enables an unrequested rtol and ignores an explicitly passed rtol. Also throws on a zero-dimensional tensor (maximum over empty collection).

src/tensors/diagonal.jl:366-378.

Activity

  1. linked a pull request that will close this issueRelease v0.17.2 #550on Sep 20, 2026
  2. added a commit that references this issue on Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions