Repository navigation
Fix views of arrays that do not start at the beginning of their memory - #61
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lkdvos
force-pushed
the
ld-array-offset
branch
from
October 13, 2026 16:41
28c5260 to
ec2c847
Compare
lkdvos
enabled auto-merge (squash)
October 14, 2026 00:19
Jutho
approved these changes
Oct 14, 2026
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Julia ≥ 1.11, an
Arrayparent is normalized to itsMemory(A.ref.mem), which drops the offset ofA.refinto that memory. Arrays that do not start at the beginning of their memory, e.g. afterpopfirst!ordeleteat!at the front, or reshapes of those, therefore give views that are shifted:This also shifts reads and writes through Strided.jl and pointers handed to BLAS.
The fix lets
_normalizeparent(A, offset)return the normalized parent together with the matching offset, so the two cannot get out of sync (the PtrArrays extension is updated accordingly). For anArraythis adds the memory offset ofA.ref. There are tests for reading, slicing, writing andpointer. Julia 1.10 normalizes viareshape, which keeps the offset, and was not affected.This leaves the version alone, to be released after #60.
🤖 Generated with Claude Code