Repository navigation
Avoid redundant normalization when transforming strided views - #58
Merged
Merged
Conversation
Jutho
reviewed
Oct 7, 2026
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Instead of calling the fully parameterized inner constructor at every
call site that reuses an already-normalized parent, let the outer
`StridedView`/`StridedView{T}` constructors take `normalize = false`
to skip parent and stride normalization.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lkdvos
enabled auto-merge (squash)
October 8, 2026 23:09
Jutho
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse normalized parents when transforming existing views. Operation-only transformations and equal-size reinterpretation also reuse strides; permutations, slices, and reshapes retain stride normalization. Return the existing view for a same-shape
sreshape.Small Julia 1.13.1 / BenchmarkTools measurements on
StridedView(zeros(ComplexF64, 8, 9, 10, 11))(minimum of 1,000 samples):conj(a)permutedims(a, (4, 2, 1, 3))sreshape(a, size(a))All cases remain allocation-free. The permutation retains normalization, so its timing is effectively unchanged.
Validated 1,321 existing CPU checks and 266 focused layout checks, including negative strides, offsets, singleton/empty axes, and rank changes.