Skip to content

Preserve parent alias checks for StridedViews #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 2 commits into from
Oct 6, 2026
Merged

Preserve parent alias checks for StridedViews #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e259875
Delegate StridedView alias checks to dense parents
lkdvos Oct 5, 2026
d911be1
Simplify alias regressions to use JLArrays
lkdvos Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/stridedview.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,9 @@ function Base.elsize(::Type{<:StridedView{T, N, A}}) where {T, N, A}
return Base.elsize(A)
end
Base.dataids(a::StridedView) = Base.dataids(a.parent)

# The parents may have a more precise alias check than their shared-storage dataids.
# Disjoint parents imply disjoint views; overlapping parents remain conservative.
function Base.mightalias(a::StridedView, b::StridedView)
return !isempty(a) && !isempty(b) && Base.mightalias(parent(a), parent(b))
end
14 changes: 14 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,20 @@ if !is_buildkite
end

@testset "JLArrays with StridedView" begin
@testset "alias detection" begin
buffer = JLArray{Float32}(undef, 16)
left = view(buffer, 1:8)
right = view(buffer, 9:16)
overlap = view(buffer, 5:12)
# Preserve the parents' alias check, including byte-range specializations.
for other in (left, right, overlap)
@test Base.mightalias(StridedView(left), StridedView(other)) ==
Base.mightalias(left, other)
end
empty = sview(StridedView(left), 3:2)
@test !Base.mightalias(empty, StridedView(left))
@test !Base.mightalias(StridedView(left), empty)
end
@testset for T in (Float64, ComplexF64)
Araw = randn(T, 10, 10, 10, 10)
A = JLArray(Araw)
Expand Down
Loading