Skip to content

Avoid redundant view construction in broadcast shape promotion #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 1 commit into from
Oct 7, 2026
Merged

Avoid redundant view construction in broadcast shape promotion #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ function promoteshape(sz::Dims, a1::StridedView, As...)
end
promoteshape(sz::Dims) = ()
function promoteshape1(sz::Dims{N}, a::StridedView) where {N}
size(a) == sz && return a
newstrides = ntuple(Val(N)) do d
if size(a, d) == sz[d]
stride(a, d)
Expand All @@ -81,7 +82,12 @@ function promoteshape1(sz::Dims{N}, a::StridedView) where {N}
throw(DimensionMismatch("array could not be broadcasted to match destination"))
end
end
return StridedView(a.parent, sz, newstrides, a.offset, a.op)

# bypass default constructor to avoid unnecessary stride normalization:
# a is already normalized, singleton-axis strides do not affect iteration.
return StridedView{eltype(a), N, typeof(a.parent), typeof(a.op)}(
a.parent, sz, newstrides, a.offset, a.op
)
end

struct CaptureArgs{F, Args <: Tuple}
Expand Down
Loading