Skip to content

Avoid returning unused views from generated kernels #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 4 commits into from
Oct 7, 2026
Merged

Avoid returning unused views from generated kernels #86

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe4cf1f
fix small bug for reduction into offset singleton
lkdvos Oct 7, 2026
e53d582
Test complete reductions into offset views
lkdvos Oct 7, 2026
ace0db3
kernels consistently return `nothing` to avoid unused boxed return va…
lkdvos Oct 7, 2026
31a8172
Merge branch 'main' into ld-kernel-return-nothing
lkdvos Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mapreduce.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ function _mapreduce_kernel_expr(f, op, initop, N::Int, M::Int)
$pre2ex
$pre3ex
@inbounds $ex
return A1
return nothing
end
else
for outer i in 1:N
Expand All @@ -527,7 +527,7 @@ function _mapreduce_kernel_expr(f, op, initop, N::Int, M::Int)
$pre3ex
$(initvars[N + 1]) = true
@inbounds $ex
return A1
return nothing
end
end
return ex
Expand Down
Loading