Repository navigation
Add OrthAdjoint for left_orth, right_orth - #465
Conversation
Codecov Report❌ Patch coverage is
... and 93 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
If this is possible, I would prefer to use one struct for both the QR and LQ pullback hooks. The |
pbrehmer
left a comment
There was a problem hiding this comment.
I agree with Lander that it would be nicer to have a single OrthAdjoint struct (and at first glance this seems straightforward to add I think?) but other than that this looks good to me!
LQAdjoint for right_orthOrthAdjoint for left_orth, right_orth
pbrehmer
left a comment
There was a problem hiding this comment.
I only have minor comments now, otherwise this is good to go for me.
Co-authored-by: Paul Brehmer <paulbrehmer8@googlemail.com>
Add
OrthAdjointfor differentiating bothleft_orth(!)andright_orth(!).QRAdjointis now its compatibility alias.They will be useful in #422 (SI-CTMRG projector) and #441 (split-CTMRG).