Repository navigation
Extend OptimKit.fixedpoint instead of exporting a separate fixedpoint - #446
Merged
Merged
Conversation
Member
|
Hmmm, this is not the prettiest but I guess it will do 🤷 |
lkdvos
approved these changes
Oct 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptimKit 0.5 exports
fixedpoint. Because PEPSKit exports afixedpointof its own, an unqualifiedfixedpointafterusing PEPSKit, OptimKitthrows anUndefVarError, which breaks the example tests and the code shown in the docs. We now add PEPSKit's methods toOptimKit.fixedpointand require OptimKit 0.5.Conceptually the two functions have little to do with each other, so this is simply the easiest solution. We could also keep PEPSKit's
fixedpointseparate, but then every script that uses both PEPSKit and OptimKit breaks.Reproducer
using PEPSKit, OptimKit fixedpoint🤖 Generated with Claude Code