Skip to content

Extend OptimKit.fixedpoint instead of exporting a separate fixedpoint - #446

Merged
leburgel merged 1 commit into
mainfrom
lb/optimkit05_fixedpoint
Oct 14, 2026
Merged

leburgel merged 1 commit into
mainfrom
lb/optimkit05_fixedpoint

Conversation

@leburgel

Copy link
Copy Markdown
Member

OptimKit 0.5 exports fixedpoint. Because PEPSKit exports a fixedpoint of its own, an unqualified fixedpoint after using PEPSKit, OptimKit throws an UndefVarError, which breaks the example tests and the code shown in the docs. We now add PEPSKit's methods to OptimKit.fixedpoint and require OptimKit 0.5.

Conceptually the two functions have little to do with each other, so this is simply the easiest solution. We could also keep PEPSKit's fixedpoint separate, but then every script that uses both PEPSKit and OptimKit breaks.

Reproducer
using PEPSKit, OptimKit
fixedpoint

🤖 Generated with Claude Code

@lkdvos

lkdvos commented Oct 13, 2026

Copy link
Copy Markdown
Member

Hmmm, this is not the prettiest but I guess it will do 🤷

@leburgel
leburgel merged commit 2979856 into main Oct 14, 2026
76 of 77 checks passed
@leburgel
leburgel deleted the lb/optimkit05_fixedpoint branch October 14, 2026 04:12
@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/PEPSKit.jl 100.00% <ø> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants