Repository navigation
Use MPSKit's logging macros and adapt_solver - #445
Merged
Merged
Conversation
…ggingExtras verbosity macros and updatetol
lkdvos
approved these changes
Oct 13, 2026
Member
Author
|
Also force merging this one, since it's approved and test failures are resolved on main. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPSKit 0.14 allows LoggingExtras 1.2, which deprecates
@infov,@warnvandwithlevel(; verbosity). MPSKit 0.14 also deprecatesupdatetolin favour ofadapt_solver. UnderPkg.test, these deprecations print 136 and 65 warnings respectively in the Julia 1 ubuntu jobs of run 38291840013.We now log through MPSKit's
with_verbosityand its@log_*macros, and drop the LoggingExtras dependency. CTMRG verbosity levels are unchanged. The BP init message and the simple-update header and timing lines move from verbosity 1 to 2.🤖 Generated with Claude Code