Repository navigation
Use the full corner inverse in C4v characteristic equations for C4vQRProjector - #435
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 94 files with indirect coverage changes 🚀 New features to boost your workflow:
|
leburgel
force-pushed
the
lb/c4v_qr_corner_inverse
branch
from
October 10, 2026 17:57
066c32e to
28febd8
Compare
pbrehmer
approved these changes
Oct 12, 2026
leburgel
force-pushed
the
lb/c4v_qr_corner_inverse
branch
from
October 12, 2026 16:18
28febd8 to
4ee61c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C4v characteristic equation for the projector parametrization
ucontains the inverse of the fixed-point corner.generate_symmetric_characteristic_equationcomputed it assdiag_pow(real(DiagonalTensorMap(Cfp)), -1), which inverts only the diagonal ofCfp. That is exact forC4vEighProjector, whose fixed-point corner is the diagonal matrix of eigenvalues, but not forC4vQRProjector: its corner is the Hermitian part of the contracted edges, which is not diagonal.ImplicitGradientwithC4vQRProjectortherefore solved the wrong linear problem and returned a slightly wrong gradient.This PR selects the inverse by projector algorithm, through a new internal
_c4v_corner_inverse(projector_alg, C):C4vEighProjector: unchanged, the inverse of the diagonal.C4vQRProjector: the full inverse, computed asV * sdiag_pow(D, -1) * V'fromeigh_full(C). This uses the samesdiag_powas the diagonal case, including its cutoff on small eigenvalues.generate_symmetric_characteristic_equationtakes the projector algorithm as a newprojector_algkeyword, which theImplicitGradientrrule passes.