Skip to content

Ensure dynamic tolerance scaling works for every gradient algorithm #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leburgel merged 2 commits into from
Aug 27, 2026
Merged

Ensure dynamic tolerance scaling works for every gradient algorithm #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da6fdf8
Ensure dynamic tolerance scaling with `_updatetol` works for every gr…
leburgel Aug 25, 2026
474b30c
Compensate for modified corner type in `leading_boundary` output when…
leburgel Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/algorithms/optimization/implicit_differentiation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ function GradientAlgorithm(;
return alg_type(solver)
end

# a `GradientAlgorithm` has no top-level `tol` field (it lives on `solver_alg`), so the
# default `MPSKit.DynamicTols._updatetol` (which sets `alg.tol`) doesn't apply
_updatetol(alg::GradientAlgorithm, tol::Real) = @set alg.solver_alg.tol = tol

#
# Fixed-point gradient computation
#
Expand Down Expand Up @@ -95,10 +99,6 @@ end
FixedPointGradient(; kwargs...) = GradientAlgorithm(; alg = :FixedPointGradient, kwargs...)
GRADIENT_ALGORITHM_SYMBOLS[:FixedPointGradient] = FixedPointGradient

# `FixedPointGradient` has no top-level `tol` field (it lives on `solver_alg`), so the
# default `MPSKit.DynamicTols._updatetol` (which sets `alg.tol`) doesn't apply
_updatetol(alg::FixedPointGradient, tol::Real) = @set alg.solver_alg.tol = tol

const FIXEDPOINT_SOLVER_SYMBOLS = IdDict{Symbol, Type{<:Any}}(
:GMRES => GMRES, :BiCGStab => BiCGStab, :Arnoldi => Arnoldi,
)
Expand Down
11 changes: 11 additions & 0 deletions src/environments/ctmrg_environments.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,17 @@ function update!(env::CTMRGEnv{C, T}, env´::CTMRGEnv{C, T}) where {C, T}
env.edges .= env´.edges
return env
end
# patch for the case where the corners are of a different type, which happens when running
# variational optimization using an implicit gradient
function update!(env::CTMRGEnv{C, T}, env´::CTMRGEnv{C´, T}) where {C, C´, T}
env.corners .= _convert_cornertype.(C, env´.corners)
env.edges .= env´.edges
return env
end
function _convert_cornertype(::Type{C}, c) where {C <: DiagonalTensorMap}
d = DiagonalTensorMap(c)
return scalartype(C) <: Real ? real(d) : d
end

# Rotate corners & edges counter-clockwise
function Base.rotl90(env::CTMRGEnv{C, T}) where {C, T}
Expand Down
5 changes: 3 additions & 2 deletions test/examples/heisenberg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ end
@test all(@. ξ_h > 0 && ξ_v > 0)
end

@testset "C4v AD optimization with scalartype T=$T and projector_alg=$projector_alg" for (T, projector_alg) in
Iterators.product([Float64, ComplexF64], [:C4vEighProjector, :C4vQRProjector])
@testset "C4v AD optimization with scalartype T=$T, projector_alg=$projector_alg and gradient_alg=$gradient_alg" for (T, projector_alg, gradient_alg) in
Iterators.product([Float64, ComplexF64], [:C4vEighProjector, :C4vQRProjector], [:FixedPointGradient, :ImplicitGradient])
# initialize symmetric states
Random.seed!(123456789)
symm = RotateReflect()
Expand All @@ -69,6 +69,7 @@ end
H, peps₀, env₀;
optimizer_alg = (; tol = gradtol, maxiter = 25),
boundary_alg = (; alg = :C4vCTMRG, projector_alg, maxiter = 500),
gradient_alg = (; alg = gradient_alg),
)
ξ_h, ξ_v, = correlation_length(peps, env)
@info "Optimized energy = $E."
Expand Down
Loading