Skip to content

Go back to QRIteration for default SVD algo on AMD - #308

Merged
kshyatt merged 1 commit into
mainfrom
ksh/amd_qriteration
Oct 15, 2026
Merged

kshyatt merged 1 commit into
mainfrom
ksh/amd_qriteration

Conversation

@kshyatt

@kshyatt kshyatt commented Oct 14, 2026

Copy link
Copy Markdown
Member

I tried using Bisection to avoid ROCm/rocm-libraries#12188 and accuracy issues with Jacobi, but this caused lots of other problems because Bisection isn't great at handling degenerate singular values. So I think it makes sense to go back to QRIteration because the above issue I only saw rarely with PEPSKit on AMDGPU, which effectively nobody is using.

@kshyatt
kshyatt requested a review from lkdvos October 14, 2026 15:55
@kshyatt
kshyatt enabled auto-merge (squash) October 14, 2026 20:00
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
...ixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl 73.77% <33.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kshyatt
kshyatt merged commit bcccb38 into main Oct 15, 2026
47 of 48 checks passed
@kshyatt
kshyatt deleted the ksh/amd_qriteration branch October 15, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants