Repository navigation
Fix UndefRefError from LoweredCodeUtils from InfiniteMPS method signatures - #540
Merged
Merged
Conversation
Member
|
fair enough, can you also open an issue for Revise itself? |
lkdvos
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No clue what the origin of the issue was, so I asked my robot friend for a fix and a brief explanation. Here me paraphrasing it: "Writing
S <: Union{Int, <:IndexSpace}puts an anonymous type variable inside the bound ofS. For methods with keyword arguments, Revise (through LoweredCodeUtils) re-runs the method's signature to find the generated keyword-body function. It doesn't handle that inner type variable correctly, fails withUndefRefError, and skips the method with a warning.Union{Int, <:IndexSpace} == Union{Int, IndexSpace}, so writingS <: Union{Int, IndexSpace}defines the same methods and avoids the warning."This would occasionally freeze my REPL in some Revise retrigger, which was very annoying.
Checklist
julia --project=test test/runtests.jl, or the relevant subset)docs/src/)[Unreleased]indocs/src/changelog.md, if this PR is user-facing (new feature, behavior change, bug fix, deprecation, or removal)