fix: parse multiple audioStreamMode entries in TalkAbility (#371)#415
Open
nythtech-nl wants to merge 1 commit into
Open
fix: parse multiple audioStreamMode entries in TalkAbility (#371)#415nythtech-nl wants to merge 1 commit into
nythtech-nl wants to merge 1 commit into
Conversation
…tangledAndy#371) The Reolink Video Doorbell advertises more than one <audioStreamMode> in its TalkAbility response (followVideoStream and mixAudioStream). The deserializer modelled audio_stream_mode as a single String, so the second element triggered serde's "duplicate field audioStreamMode" error and neolink wrongly reported "does not support talk". Make AudioStreamModeList.audio_stream_mode a Vec<String> and select the first advertised mode when building the TalkConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
neolink talkfails for the Reolink Video Doorbell with:The doorbell's
TalkAbilityresponse advertises two<audioStreamMode>values:but
AudioStreamModeList.audio_stream_modeis a singleString, so serde rejects the second element as a duplicate field and neolink wrongly concludes the camera cannot talk.Fixes #371.
Fix
AudioStreamModeList.audio_stream_modeaVec<String>(#[serde(default)]).TalkConfig.Testing
Built from this branch and ran
neolink talkagainst a Reolink Video Doorbell behind an RLN12W NVR (talk routed viachannel_id). Before: "does not support talk". After: TalkAbility parses, the talk pipeline streams, and audio plays from the doorbell speaker. Cameras that advertise a single mode are unaffected (.first()yields the same value).