Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(deps): complete Gate_SDK @v1 pin — lock, validator, and hook #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(deps): complete Gate_SDK @v1 pin — lock, validator, and hook #282
Changes from all commits
72877f36e32738eb6d0850eb838dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Check failure on line 26 in scripts/validate_sdk_pin.py
Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When either manifest uses a revision such as
v10orv1-malicious, this substring check still findsv1and returns no error, so the repository-tree test approves a dependency that violates the required@v1policy. Parse theconstellation-node-sdkdeclaration and compare its revision exactly instead of searching the whole file.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.