Skip to content

fix(test): repair the fail-closed enrichment assertion that is red on main #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptoxdog merged 3 commits into from
Sep 19, 2026
Merged

fix(test): repair the fail-closed enrichment assertion that is red on main #264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c71ab1f
fix(test): assert idempotency_key in fail-closed enrichment result
claude Sep 18, 2026
b776c8b
test(gate-egress): assert idempotency_key on the SDK-error return
claude Sep 18, 2026
9c69038
test(gate-egress): match PR #262's fail-closed hunk byte-for-byte
claude Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/unit/test_gate_egress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@ async def test_request_enrichment_fails_closed_without_gate_url(monkeypatch: pyt
fake = _FakeClient(response=_response_packet())
monkeypatch.setattr(gate_egress, "get_gate_client", lambda: fake)
result = await request_enrichment(tenant="acme", entity_id="ent-1", domain="plasticos", target_fields=["polymer"])
assert result == {"status": "failed", "error": "gate_not_configured", "action": "enrich"}
assert result == {
"status": "failed",
"error": "gate_not_configured",
"action": "enrich",
"idempotency_key": enrichment_idempotency_key("acme", "ent-1", ["polymer"]),
}
assert fake.calls == [], "no direct fallback: nothing may be sent when Gate is not configured"


Expand Down Expand Up @@ -114,6 +119,7 @@ async def test_request_enrichment_reports_sdk_errors_as_failure(monkeypatch: pyt
result = await request_enrichment(tenant="acme", entity_id="ent-1", domain="plasticos", target_fields=["polymer"])
assert result["status"] == "failed"
assert result["error"] == "GateConnectionError"
assert result["idempotency_key"] == enrichment_idempotency_key("acme", "ent-1", ["polymer"])
assert len(fake.calls) == 1


Expand Down
Loading