chore: pin constellation-node-sdk to @v1 (moving major tag) - #263
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ PR reviewable size is within recommended limits |
L9 Audit Harness Report
Step Results
Architecture Audit Findings
See Spec Coverage
See Next StepsAll checks passed. Safe to merge. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29bc0a2ecf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟡 Changes recommended
poetry.lock is still pinned to the old SDK commit, so Poetry-based installs/builds will not actually adopt the v1 ref (and may fail lock consistency checks).
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the project’s dependency pin for constellation-node-sdk (from the Gate SDK repo) to follow the moving major ref v1, so consumers can automatically pick up future v1.x updates without re-pinning to a new commit SHA.
Changes:
- Update
requirements.txtVCS dependency toQuantum-L9/Gate_SDK.git@v1. - Update
pyproject.tomlPoetry git dependencyrevtov1.
File summaries
| File | Description |
|---|---|
| requirements.txt | Switches the pip VCS dependency from a fixed commit SHA to the v1 ref. |
| pyproject.toml | Switches the Poetry VCS dependency from a fixed commit SHA to the v1 ref. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR Remediation — Cycle 1 SummaryCommit: Fixed (0)none Deferred (3)
Acknowledged (0)none Disagreed (0)none Local verify: Failed | Threads resolved: 3/3 |
* fix(deps): complete Gate_SDK @v1 pin — lock, validator, and hook PR #263 adopted the moving major tag in the manifests. Sync poetry.lock to that tag and replace the SHA fail-closed check so main is coherent. Issue-Remediation-Cycle: #266/cycle-1 Co-authored-by: Cursor <cursoragent@cursor.com> * style: commit gate writer rewrites so make pr finishes once * fix(deps): keep @v1 pin off Makefile/pre-commit overlap with #280 Leave Make/hook wiring to the cypher-lint PR that already owns those files. The lock and validator still complete the #263/#266 decision. Issue-Remediation-Cycle: #266/cycle-1 Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Align SDK pin to the moving major tag
@v1(Gate_SDK v1.1.0 @ main).Replaces the commit-SHA pin so
@v1auto-adopts future v1.x releases without a PR in every consumer. Wire schema (transport/packet.py) verified identical to the prior pin;GateClient.executepresent.Part of the coordinated Gate/CEG/EIE/Odoo seam alignment.