#262 blocked by Enforce PR Policies (1239 vs 1000 additions) — needs a split, a test-file exclusion, or a threshold decision

[cryptoxdog]

Enforce PR Policies blocks #262 and cannot be cleared by editing the remediation. Filed for an owner decision.

Current state

Reviewable PR stats: +1239 -246, 12 files
Thresholds: warn=300, block=1000 (additions-only), maxFiles=50

How it got here

	additions
#262 before any audit remediation (0058b0e)	969
Block threshold	1000
Headroom on arrival	31
CEG-262-002/003 schema precondition + protocol body	+63 → 1032
CEG-262-002 real-Neo4j concurrency validation	+193 → 1239

The branch arrived at 97% of its additions budget, so any substantive remediation tips it over. Both commits are the closing validations the audit requires; removing either to satisfy a line count would delete the fix rather than repair it.

Removing the unrelated CI changes does not help

This was my first hypothesis and it is wrong — worth recording so nobody retries it. The gate blocks on additions only (deletions are explicitly excluded so deletion-heavy migrations are not penalised twice), and the out-of-scope CI/governance edits are nearly free in additions:

  1 +  .github/workflows/ci.yml
  1 +  .github/workflows/supply-chain.yml
  6 +  .github/governance/quality-thresholds.yaml
  0 +  .github/workflows/l9-analysis.yml   (-186)

The volume is the feature itself:

587 +  engine/sync/idea_portfolio.py
193 +  tests/integration/test_idea_portfolio_hydration.py
183 +  tests/unit/test_idea_portfolio.py
148 +  domains/idea-portfolio/spec.yaml
108 +  tools/hydrate_idea_portfolio.py

So resolving #265 improves scope hygiene and removes six Sonar findings, but it will not bring this PR under 1000.

Options

1. Split the feature, per the policy's own guidance. The natural seam is the hydration engine plus its spec in one PR, and the CLI plus tests in a follow-up.
2. Exclude test files from additions accounting. tests/integration/test_idea_portfolio_hydration.py (+193) and tests/unit/test_idea_portfolio.py (+183) are 30% of the total; counting proof-of-correctness against a reviewability budget penalises the thing the audit asked for. The workflow already has an ignore mechanism for generated files.
3. Raise the threshold for this PR, accepting it as a single reviewable feature.

I can execute (1) or (2) on request; neither is a decision I should take unilaterally.

Related: #262, #265.

---

Generated by Claude Code

[cryptoxdog]

Closing — the premise is gone. #262 merged as d26194d, so there is no longer a PR sitting over the reviewable-size limit.

For the record, since the underlying question outlives this issue: the branch reached +1253 against a 1000 limit, having arrived at +969 before any remediation. The audit's required closing validations (the schema precondition, and the real-Neo4j concurrency test) accounted for +284 of that. The options in the issue body — splitting the feature, or excluding test files from additions accounting — were never exercised; the PR merged with the gate red.

The general point still stands and may be worth its own issue if it recurs: counting test additions against a reviewability budget penalises exactly the evidence a reviewer most wants, and the workflow already has an ignore mechanism for generated files that could be extended.

---

Generated by Claude Code