Repository navigation
test: refresh visual baselines after the View Source change (#453) - #457
Conversation
Starter commit for the snapshot refresh; the regenerated baselines are added by /update-snapshots once #456 is on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
=======================================
Coverage ? 59.48%
=======================================
Files ? 2
Lines ? 548
Branches ? 0
=======================================
Hits ? 326
Misses ? 222
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎭 Visual Regression Test ResultsDetails
Skipped testsdesktop-chrome › theme.spec.ts › Visual Regression Tests › prob-matrix - full page screenshot |
|
/update-snapshots |
|
✅ Regenerated visual snapshots and committed 39 changed file(s) to this PR. Built against fixtures ✅ Re-ran the suite against the new baselines — they reproduce. 📦 Download snapshot-update-diff artifact for the regenerated images; this PR's Files changed tab shows each one before and after.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Refreshes the Playwright baselines so they match what the fixtures site renders today. They were regenerated by
/update-snapshots, the first run with #456's--update-snapshots=allfix, against fixtures0048d10, and the bot's re-run confirmed they reproduce.What changed (39 files)
I diffed every old and new baseline pixel by pixel and looked at crops of each kind of change. Nothing is unexplained:
toolbar.pngand 27 full-page shots (both devices,dark-mode.pngincluded)repository_url, so the View Source button is no longer rendered. Each file's change is the same: desktop x 959–1250 / y 15–34, mobile x 265–370 / y 15–34intro.png,intro-sidebar.png(both devices); also the header of every full-page shot. On desktopmath.pngandadmonitions.pngit makes the page 3 px tallerchanged-mode bot never captured itbold-text-dark.png,italic-text-dark.pngbold-text,italic-text, their dark variants,code-blockCI
On the empty commit pushed after the bot's commit, everything passes: the
visualjob had 103 passed, 3 skipped, and 0 flaky.Unrelated flakiness still there
Math-heavy pages still sometimes render at a different height, and a size mismatch fails
toHaveScreenshotwhatever the tolerance. This existed before this PR and the refresh doesn't fix it:main's CI for the ci: make /update-snapshots regenerate all baselines again #456 merge (f43b75d) failedvisualon desktopmath: baseline 3006 px, received 2939–2942 px on every retry.main) failed mobilelong-page(5911 vs 5901–5902 px) and mobile "math equation rendering".long-pagewas 5911 px, matching the old baseline, so the height varies from run to run rather than having changed.So one clean run here doesn't show the flakiness is gone. Tracked in #463, which traces it to MathJax sizing math before the web font has loaded.
No CHANGELOG entry, since a baseline refresh isn't user-facing.
🤖 Generated with Claude Code