Repository navigation
laffer_adaptive: import matplotlib is unused (missed by #798) #800
Description
lectures/laffer_adaptive.md imports matplotlib but never uses it. The only matplotlib-prefixed reference in the lecture is the matplotlib.pyplot and matplotlib.ticker imports themselves — nothing calls matplotlib.<anything>.
The import block currently reads:
| line | import | used? |
|---|---|---|
| 170 | from collections import namedtuple |
yes |
| 171 | import numpy as np |
yes |
| 172 | import matplotlib.pyplot as plt |
yes |
| 173 | from matplotlib.ticker import MaxNLocator |
yes |
| 174 | import matplotlib |
no |
| 175 | from scipy.optimize import root, fsolve |
yes |
This was missed by #798, which removed the unused get_cmap and to_rgba imports from this same block and left import matplotlib one line below them. Dropping line 174 finishes that cleanup.
How it surfaced
Copilot review flagged it on the Chinese edition's sync PR for #798 — QuantEcon/lecture-intro.zh-cn#268. It is not being fixed there: the line is inherited from this repo, so patching it in a translation edition would create drift from source on non-localisation grounds and would likely be reintroduced by the next resync. Fixing it here lets it flow down through the normal sync instead.
(For the record, the Chinese edition separately carries import matplotlib as mpl, which is used — it registers the CJK font. That one is a legitimate localisation addition and is unaffected.)
Happy to send a one-line PR if useful.
🤖 Generated with Claude Code
Activity