Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an optional desired state for IB Gateway's Use Account Groups with Allocation Methods setting. It is the IBAutomater prerequisite for LEAN's unified financial-advisor group routing.
There have been historical PRs that have flipped the group allocation setting back and forth. The IB API behaves differently based on if this setting is selected for advisors. This update, in combination with the linked PRs open in the other repos, makes this setting user definable to ensure it has the correct setting for the deployment. The default is its existing behavior. The bug fix component addresses that the existing IBAutomater desired outcome for this setting wasn't reached across IBGateway versions that have different punctuation for the setting from what the existing code realized.
This closes: QuantConnect/IBAutomater#112
** This is part of a coordinated multi-repo feature release. See the attached files for thorough details**
Hosted QuantConnect Cloud availability additionally requires the deployment schema/UI to expose and serialize the corresponding brokerage setting.
Behavior
The result reports whether the recognized Swing control reached the requested state.
Compatibility
false.Validation
Related work and sequencing
The coordinated PRs can be reviewed concurrently, but their release has package and platform dependencies:
The hosted deployment schema/UI must expose the unified-groups and group-management inputs under their exact brokerage-data keys. That platform work is external to this repository.
Files attached explaining the full fav2 linked PR scope across repos, and testing conducted
fav2_live_verification_report.md
fav2_enhancement_summary.md
enhancement_change_inventory.md
enhancement_goals_findings.md
enhancement_scope.md
test_file_scope.md
Types of changes
Checklist: